feat: improve type safety for flow step outputs and skippable dependencies#583
Conversation
|
This was referenced Jan 8, 2026
Contributor
Author
This was referenced Jan 8, 2026
|
View your CI Pipeline Execution ↗ for commit dfe0535
☁️ Nx Cloud last updated this comment at |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
jumski
force-pushed
the
01-06-fix_step_array_map_overloads_to_use_topts_intersection_pattern_for_skippability_detection
branch
from
238c72d to
bb09b62
Compare
This was referenced Jan 9, 2026
jumski
force-pushed
the
01-06-fix_step_array_map_overloads_to_use_topts_intersection_pattern_for_skippability_detection
branch
from
bb09b62 to
6be7361
Compare
jumski
force-pushed
the
01-06-add_stepmeta_type_structure_for_skippable_deps_tracking
branch
from
14ed89d to
af7d04a
Compare
jumski
force-pushed
the
01-06-fix_step_array_map_overloads_to_use_topts_intersection_pattern_for_skippability_detection
branch
from
6be7361 to
7a9134a
Compare
jumski
force-pushed
the
01-06-add_stepmeta_type_structure_for_skippable_deps_tracking
branch
from
af7d04a to
bdabd07
Compare
…ippability detection
jumski
force-pushed
the
01-06-add_stepmeta_type_structure_for_skippable_deps_tracking
branch
from
bdabd07 to
fa989a4
Compare
jumski
force-pushed
the
01-06-fix_step_array_map_overloads_to_use_topts_intersection_pattern_for_skippability_detection
branch
from
7a9134a to
dfe0535
Compare
Contributor
Author
|
Folded into #572 (squashed conditional steps PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved Type Safety for Flow Steps and Skippable Dependencies
This PR enhances the type system for Flow steps and skippable dependencies:
Refactored
ExtractFlowStepsto return step slugs as keys, and introduced a newStepOutput<>utility type to get the output type from a specific step.Updated type tests to use the new
StepOutput<>type for accessing step output types, providing a clearer and more consistent API.Added comprehensive compile-time error tests for skippable dependencies to ensure TypeScript correctly rejects invalid patterns:
whenUnmet: 'skip'andretriesExhausted: 'skip'optionsThese changes improve the developer experience by providing better type safety and clearer error messages when working with potentially skipped steps in flows.